search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

[Bug]: Transactions - When I retry a failed transaction with a successful result, I don't see the status updated for that tx, it continues to display `Failed` #28615

Open seaona opened 4 days ago

seaona commented 4 days ago

Describe the bug

When I retry a failed transaction with a successful result, I don't see the status updated for that tx, it continues to displayed Failed. You can see in Etherscan how the tx was successful.

Expected behavior

If we retry a transaction, we should update its status (switch first to Pending and then to Successful/Failed depening on its new result). Additionally, the activity log for that tx should also display the new actions of retry etc.

Screenshots/Recordings

https://github.com/user-attachments/assets/c70748fa-72f0-480f-842f-da80fde96844

Steps to reproduce

One easy way to reproduce this is using a hardware wallet and rejecting the first tx there to reach into a failed status that we can retry. But there might be multiple ways to reach this:

  1. Import Ledger
  2. Perform a send from the wallet
  3. Reject the tx on Ledger
  4. See tx status as Failed
  5. Click the tx
  6. Click Retry
  7. Confirm the retry on Ledger
  8. Wait
  9. See how the tx remains in the Failed status
  10. Go to Etherscan
  11. See how the tx was successful

Error messages or log output

No response

Detection stage

In production (default)

Version

12.6.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response