MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

fix: Replace `AvatarAccount` with `Identicon` #28645

Open OGPoyraz opened 6 hours ago

OGPoyraz commented 6 hours ago

Description

This PR fixes icon issue on confirmations mentioned on https://github.com/MetaMask/metamask-extension/issues/28609

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/28609

Manual testing steps

  1. Go to settings - select Blockies icons
  2. Trigger a signature or contract interaction
  3. See the addresses there are displayed in Blockies
  4. Go to settings - select JazzIcons
  5. Trigger a signature or contract interaction
  6. See the addresses there are displayed in JazzIcons

Screenshots/Recordings

Before

before

After

after

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented 6 hours ago
Builds ready [95fb76a]
Page Load Metrics (1785 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48820501722305146
domContentLoaded16332034175410751
load16442059178511756
domInteractive15119372412
backgroundConnect10109322512
firstReactRender492931286632
getState484222311
initialActions00000
loadScripts11751565128710249
setupStore667172010
uiStartup18422474204618890
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -121 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)