MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.94k forks source link

[Bug]: BTC account name not updated #28831

Open javiergarciavera opened 1 day ago

javiergarciavera commented 1 day ago

Describe the bug

Given a user has a BTC account created on Metamask When the user changes the BTC account details with a new value And the user starts a new send transaction Then account details shows the old value

Expected behavior

Given a user has a BTC account created on Metamask When the user changes the BTC account details with a new value And the user starts a new send transaction Then account details shows the new value

Screenshots/Recordings

https://www.loom.com/share/02fd9a751bd8461a8ac6a6021971d1ab?sid=3b760571-7dc5-4bac-bbe0-b0a3781eee4d

Steps to reproduce

  1. Create a BTC account
  2. Go to account details and change the name
  3. Click on send button Expected:
  4. From tx field shows the new name Current:
  5. From tx field shows the old value

Error messages or log output

Detection stage

In production (default)

Version

7.12.0

Build type

Flask

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

ccharly commented 18 hours ago

This is due to a limitation with the current implementation.

This is the same behavior since the introduction of the Bitcoin send flow (v12.6.0). For the moment we are using this a hardcoded account name because there's no easy way to fetch the account names from the extension for a Snap.

There is some on-going work to have better components to handle everything related to accounts (AccountPicker and Address components). Those are not yet available on the Snap UI.

So to me, we should not consider this a bug for the moment and definitely not a release-blocker. This will be fixed once those components are available.

cc: @gantunesr @montelaidev

gantunesr commented 15 hours ago

We'll fix this in a follow up release cc @Montoya