search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12k stars 4.91k forks source link

NewUI: "Reveal seed phrase" password screen still using old UI #3168

Closed danfinlay closed 6 years ago

danfinlay commented 6 years ago

Celine made an updated UI design for this.

alextsg commented 6 years ago

@cjeria Can you add a link to the design for this? Thanks.

cjeria commented 6 years ago

@celinepark94 can you add your designs for this screen here for review?

cjeria commented 6 years ago

@celinepark94 I found your designs and iterated on them.

Posting here for feedback.

image

alextsg commented 6 years ago

Will the dual button Copy to clipboard/Save as CSV File component be used elsewhere in the app?

cjeria commented 6 years ago

@alextsg possibly. Right now, this is an ongoing discussion/critique of this design. Would like to get us providing feedback and get some iterations before committing.

To address your question, we may consider using a similar component when accessing account private keys.

Please feel free to share any thoughts/concerns.

image

cjeria commented 6 years ago

Or how about a component like this and use tooltips

image

danfinlay commented 6 years ago

I really like the idea of the animated 8-bit robber + fox. Definitely would grab the eye, help make the point. We should make a bounty for that animation and post it on some 8-bit art forum.

cjeria commented 6 years ago

@danfinlay I don’t know. This almost seems too playful. The illustration/animation would need to be very well executed and cohesive with the message we’re trying to convey. I’m Also concerned about the layout that @lazaridiscom is suggesting. The horizontal area under the seedphrase field is very narrow. Not sure that’s the best placement for an animation + message to be placed side by side. I believe using the area above the seedphrase (stacking the illustration above the warning message) makes more sense to give the ui more vertical breathing room and make it feel less cramped.

I do think we need to come up with a well defined illustration style (which is part of a bigger conversation around our branding, which I feel is underdeveloped aside from our beloved fox logo). In fact, I think we should contract a good illustrator that can be our go-to for our illustration needs, which ensures consistency because it's created by the same creator. If they know how to animate, that would be a plus, but not required IMO as we can outsource animators as well.

I’d rather us be strategic about this and come up with a cohesive look and feel (throughout the app, website, social media) as opposed to a hodgepodge of different illustration styles with no clear art direction.

That being said, I’m open to doing something fun as @lazaridiscom is suggesting and I'm also happy to research illustrators that fit the aesthetic we're going for (which we haven't really defined this as a team).

cjeria commented 6 years ago

related to https://github.com/MetaMask/metamask-extension/issues/3059