search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.66k stars 4.78k forks source link

Add timeout to all spinners #3253

Open cjeria opened 6 years ago

cjeria commented 6 years ago

I'm getting an infinite spinner after first TX screen and before the confirm screen.

See gif infinite spinner after sending eth

cjeria commented 6 years ago

I'm forced to refresh the page. We should be timing out infinite spinners like this throughout the app, even if it's a bug that should be fixed, just leaving the user guessing is never good UX. We should contextualize and provide appropriate messaging in these cases and redirect users to try again. In this case, we should add a message like "Something went wrong" after time out and give users the option the "Try Again" and link to a new TX.

cjeria commented 6 years ago

Suggested error message

image

Gudahtt commented 3 years ago

Since this bug is rather old and didn't have reproduction steps, I've converted this issue into an "enhancement", so we can track replacing all of our spinners with spinners that timeout.