search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.86k stars 4.84k forks source link

Integrate Simplex #4867

Open bdresser opened 6 years ago

bdresser commented 6 years ago

Simplex is a retail exchange licensed in the EU. Providing more options to get users up & running with their first ETH can generally help with onboarding and usability.

The Simplex team will take the lead on integrating this into the extension.

The entry point should live on the "Deposit" page / popup, which shows after a new user completes onboarding.

Probably makes sense to build this in to the new UI, as we'll be moving users off the old one shortly.

For more detail: Meta Mask - Simplex.pdf

heads up @whymarrh @alextsg @danfinlay

Markfaber commented 6 years ago

Please can you let us know what technology stack you use in your web extension?

whymarrh commented 6 years ago

@Markfaber what information specifically are you looking for?

Markfaber commented 6 years ago

what technology are you using - react, redux etc??

whymarrh commented 6 years ago

@Markfaber the UI is using React and Redux, we use redux-thunks for async actions

Markfaber commented 6 years ago

ok - thanks.

On Thu, Aug 2, 2018 at 6:06 PM Whymarrh Whitby notifications@github.com wrote:

@Markfaber https://github.com/Markfaber the UI is using React and Redux, we use redux-thunks for async actions

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/4867#issuecomment-409959120, or mute the thread https://github.com/notifications/unsubscribe-auth/AoF3ki7G7LgS_Ftf-mLflm4CkdejZ5Juks5uMxWSgaJpZM4VdNPJ .

-- Mark Faber VP Customer Success Skype: fabermark

https://www.simplex.com/ www.simplex.com

https://www.facebook.com/Simplex.cc https://twitter.com/SimplexCC https://www.linkedin.com/company/simplexcc https://www.glassdoor.com/Overview/Working-at-Simplex-Israel-EI_IE1366394.11,25.htm

Markfaber commented 6 years ago

Update: We are looking in to various design options to complete this integration. Will update when we can.

bdresser commented 6 years ago

@Markfaber after chatting with the team, it may make sense to build this as a standalone page outside the extension. If you provide a simple onboard/checkout flow that can route back to MetaMask, it may make it easier for you to develop and easier for us to fold in. We could pass the recipient address via query params, and simply add another button on the deposit page. You can develop the standalone flow on your own stack at your leisure. What do you think?

Markfaber commented 6 years ago

Hi Bobby, Sorry for the delayed response. Yes - that is far simpler for us and is exactly how we deal with most of our integrations. You would add a button on the deposit page which would redirect to a URL we could design and host. It would be similar to this https://partners.simplex.com/?partner=ledgerbut without the wallet address field which, as you suggest, you would send to us via a very light API. We would then add link back to MetaMask at the end of the checkout process. If you are OK with this we can begin designing the page and send you the integration doc to get started. Thanks Mark

On Mon, Aug 13, 2018 at 10:02 PM bobby dresser notifications@github.com wrote:

@Markfaber https://github.com/Markfaber after chatting with the team, it may make sense to build this as a standalone page outside the extension. If you provide a simple onboard/checkout flow that can route back to MetaMask, it may make it easier for you to develop and easier for us to fold in. We could pass the recipient address via query params, and simply add another button on the deposit page. You can develop the standalone flow on your own stack at your leisure. What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/4867#issuecomment-412628117, or mute the thread https://github.com/notifications/unsubscribe-auth/AoF3kizRKZhKdMrpkOpAHSongbeqd3Geks5uQc1EgaJpZM4VdNPJ .

-- Mark Faber VP Customer Success Skype: fabermark

https://www.simplex.com/ www.simplex.com

https://www.facebook.com/Simplex.cc https://twitter.com/SimplexCC https://www.linkedin.com/company/simplexcc https://www.glassdoor.com/Overview/Working-at-Simplex-Israel-EI_IE1366394.11,25.htm

bdresser commented 6 years ago

@Markfaber sounds good!

Markfaber commented 6 years ago

Hi Boby and team, Aplogies for the delay. Please see the integration doc attached. Please review and let us know if you have any questions before we progress with the hosted page. Thanks Mark

On Mon, Aug 20, 2018 at 10:09 PM bobby dresser notifications@github.com wrote:

@Markfaber https://github.com/Markfaber sounds good!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/4867#issuecomment-414428930, or mute the thread https://github.com/notifications/unsubscribe-auth/AoF3klS5HFDUw_qLNrKI8rtulufwYrRTks5uSwl7gaJpZM4VdNPJ .

-- Mark Faber VP Customer Success Skype: fabermark

https://www.simplex.com/ www.simplex.com

https://www.facebook.com/Simplex.cc https://twitter.com/SimplexCC https://www.linkedin.com/company/simplexcc https://www.glassdoor.com/Overview/Working-at-Simplex-Israel-EI_IE1366394.11,25.htm

bdresser commented 6 years ago

@Markfaber the attachment didn't come through since these emails route through github. Feel free to send to bobby.dresser@consensys.net.

Markfaber commented 6 years ago

sent

On Mon, Sep 10, 2018 at 10:51 PM bobby dresser notifications@github.com wrote:

@Markfaber https://github.com/Markfaber the attachment didn't come through since these emails route through github. Feel free to send to bobby.dresser@consensys.net.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/4867#issuecomment-420038142, or mute the thread https://github.com/notifications/unsubscribe-auth/AoF3kuZwjlBRsVrRVo55pMKVVdd3FTMyks5uZsK8gaJpZM4VdNPJ .

-- Mark Faber VP Customer Success Skype: fabermark

https://www.simplex.com/ www.simplex.com

https://www.facebook.com/Simplex.cc https://twitter.com/SimplexCC https://www.linkedin.com/company/simplexcc https://www.glassdoor.com/Overview/Working-at-Simplex-Israel-EI_IE1366394.11,25.htm

bdresser commented 5 years ago

relates to https://github.com/MetaMask/Design/issues/90

bdresser commented 5 years ago

We load the iFrame based on instructions here and can style it however we want. We then send the styles back to the Simplex team so they can update the iFrame's production environment.

Will also need to send over

Design for splash & redirect page handled in https://github.com/MetaMask/Design/issues/90