search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

An in-range update of ganache-core is breaking the build 🚨 #4936

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

Version 2.1.6 of ganache-core was just published.

Branch Build failing 🚨
Dependency ganache-core
Current Version 2.1.5
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

ganache-core is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ✅ **ci/circleci: prep-deps-firefox:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43063?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: prep-deps-npm:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43064?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: prep-scss:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43070?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-deps:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43067?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: prep-docs:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43065?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-lint:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43068?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-unit:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43066?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **coverage/coveralls:** First build on greenkeeper/ganache-core-2.1.6 at 56.819% ([Details](https://coveralls.io/builds/18280951)). - ✅ **ci/circleci: test-integration-flat-firefox:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43071?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-integration-mascara-chrome:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43074?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-integration-flat-chrome:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43072?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: prep-build:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43069?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: test-e2e-chrome:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43077?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: test-e2e-beta-chrome:** CircleCI is running your tests ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43078?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-integration-mascara-firefox:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43073?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ✅ **ci/circleci: test-e2e-firefox:** Your tests passed on CircleCI! ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43076?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **ci/circleci: test-e2e-beta-firefox:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/MetaMask/metamask-extension/43075?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)).
Release Notes v2.1.6 - Bug Fixes 🐛

Release Highlights

  • Pins ethereumjs-wallet to v0.6.0, to work around a problem with this dependency which broke HD Wallet support.
  • Switches project to use npm-shrinkwrap.json instead of package-lock.json so that projects which depend on ganache-core are getting the same dependency versions we test against.
  • Fixes a bug wherein the provider engine wasn't being stopped when the ganache-core was provider was stopped, which makes ganache-core more useful in contexts where it might need to be spun up multiple times in a single process.
Commits

The new version differs by 9 commits.

  • 030a0ec 2.1.6
  • b71713f switch to npm-shrinkwrap for tighter dependency version control
  • 7efaa6d Merge pull request #138 from frankiebee/develop
  • 6a02909 deps - pin ethereumjs-wallet to version 0.6.0
  • 92459c5 Merge pull request #133 from trufflesuite/stop-bug-fixes
  • c4918bc stop the engine when we stop the provider. fix a bug caused by it
  • f5fdbc9 Merge branch 'master' into develop
  • d896e97 Merge pull request #121 from erickearns/develop
  • f8d6d12 gasPrice should be encoded as rpc quantity hex

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 2.1.5 your tests are passing again. Downgrade this dependency 📌.

greenkeeper[bot] commented 6 years ago

Version 2.2.0 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Commits

The new version differs by 33 commits.

  • 04ff651 2.2.0
  • c6018ab Merge pull request #140 from ensdomains/develop
  • 37c117d Merge branch 'develop' into ensdomains-develop
  • e22a61d small cleanup
  • 32e1eb2 Merge branch 'develop' of https://github.com/ensdomains/ganache-core into ensdomains-develop
  • e300dae Merge pull request #149 from rmeissner/add_eth_signTypedData
  • f695f1d Use explicitly pinned versions in npm-shrinkwrap.json
  • 49d6cd0 Merge branch 'develop' into add_eth_signTypedData
  • 81e8f59 Merge pull request #141 from trufflesuite/pr/80
  • b862f2c Don't bother checking if results.gasRefund is truthy and just add with it anyway.
  • d31ae54 remove this hard-coded gas amount in the test
  • 8aa95ad Merge branch 'mine-at-timestamp' into develop
  • 06439c6 Merge branch 'develop' into mine-at-timestamp
  • c95b9a8 Add eth_signTypedData
  • 4d15706 less good.

There are 33 commits in total.

See the full diff

greenkeeper[bot] commented 6 years ago

Version 2.2.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 35 commits.

  • 119c78b 2.2.1
  • 2684b00 Add back truthy check as gasRefund can be undefined
  • 04ff651 2.2.0
  • c6018ab Merge pull request #140 from ensdomains/develop
  • 37c117d Merge branch 'develop' into ensdomains-develop
  • e22a61d small cleanup
  • 32e1eb2 Merge branch 'develop' of https://github.com/ensdomains/ganache-core into ensdomains-develop
  • e300dae Merge pull request #149 from rmeissner/add_eth_signTypedData
  • f695f1d Use explicitly pinned versions in npm-shrinkwrap.json
  • 49d6cd0 Merge branch 'develop' into add_eth_signTypedData
  • 81e8f59 Merge pull request #141 from trufflesuite/pr/80
  • b862f2c Don't bother checking if results.gasRefund is truthy and just add with it anyway.
  • d31ae54 remove this hard-coded gas amount in the test
  • 8aa95ad Merge branch 'mine-at-timestamp' into develop
  • 06439c6 Merge branch 'develop' into mine-at-timestamp

There are 35 commits in total.

See the full diff