MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.66k stars 4.78k forks source link

Metamask Electron Extension #5365

Closed EddieOne closed 5 years ago

EddieOne commented 5 years ago

What problem are you trying to solve? A lot of people are making dapps or in my case a game browser. Electron is the most advanced here. We could use an easy solution to get metamask in these applications.

Describe the solution you'd like It's pretty easy to get the Metamask extension in chromium via https://www.npmjs.com/package/electron-devtools-installer

then we can open it like so

metamaskPopup = new BrowserWindow({
  title: 'MetaMask',
  width: 360,
  height: 520,
  type: 'popup',
  resizable: false
});
var appPath = app.getPath('userData');
var metaMenu = path.join('file://', appPath, '/extensions/', METAMASK_ID, '/popup.html');

Additional context image

whymarrh commented 5 years ago

From the looks of it, Electron doesn't support Chrome extensions[1] so there isn't much we can do here.

EddieOne commented 5 years ago

I read somewhere that Brave had to mock some api in their electron fork. It must be possible, just not user friendly.

On Thu, Sep 27, 2018, 9:44 AM Whymarrh Whitby notifications@github.com wrote:

From the looks of it, Electron doesn't support Chrome extensions[1] https://github.com/electron/electron/issues/1498#issuecomment-96995155 so there isn't much we can do here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/5365#issuecomment-425142090, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwAlKc3zzTeAIJa1Ue0xqsidXQ9f8qGks5ufPIrgaJpZM4W59V_ .

DavidAmunga commented 5 years ago

Found this awesome repo which is a fork of Muon maintained by Brave. Might give it a try.

EddieOne commented 5 years ago

Thanks, that looks like what I need. Let's close this for now.

vm06007 commented 4 years ago

so how to connect metamask with Remix Desktop IDE?

iousin commented 3 years ago

so how to connect metamask with Remix Desktop IDE?

Same here please is this possible?

claudioantonio commented 2 years ago

Hey @iousin , I think It would be better to create an specific issue for Your need. 😉