MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.93k stars 4.88k forks source link

Account display screen width error #5558

Open wbt opened 5 years ago

wbt commented 5 years ago

Describe the bug When an account has a ridiculously high ETH balance, the default MetaMask account display has width issues when displaying the balance. For example, see the left and right sides of this display:

still not wide enough in beta

To Reproduce Steps to reproduce the behavior:

  1. Use Geth to set up a simple private network in which one account has an extremely large balance.
  2. Use MetaMask to connect to that private network and install the private key for the rich account. (Note that the previous bug which prevented Metamask from connecting to a private network in the new UI appears to have been fixed.)
  3. View the account.

Expected behavior The text should fit in the display, especially since it's already being abbreviated with scientific notation.
A very large balance may be elided (e.g. "904...465.124 ETH") similar to how the address is (and you should be able to click on it to copy the full value, as with the address) OR the balance may use fewer significant digits in scientific notation. In the left side of the screenshot shown, the fiat conversion also doesn't fit on the screen despite scientific notation being used.
The elided option is preferred as it allows people to more easily track changes in the smaller-value digits where changes are more likely to occur and may be of interest.

Browser details (please complete the following information):

wbt commented 5 years ago

Even with scientific notation, the font size is too big for the width of a large balance.

To Reproduce Steps to reproduce the behavior:

  1. Use Geth to set up a simple private network in which one account has an extremely large balance.
  2. Use MetaMask to connect to that private network and install the private key for the rich account.
  3. View the account: Screenshot or with government currency as primary: Screenshot

Expected behavior The number before the decimal point and the full currency symbol are visible, not just when hovering over the value. If there are fewer digits displayed, OK. If the ellipsis is moved farther left, that's OK too.

Browser details (please complete the following information):

alextsg commented 5 years ago

@wbt Thanks for reporting this. Currently working on a pull request that will fix this.

wbt commented 5 years ago

Might the issue be reopened, then, as a reminder that there's still something to work on? I just reinstalled with the latest stable release 6.1.0, and the problem seems to be getting worse rather than better.
image

damster7 commented 5 years ago

comment peux t on consulter notre solde

wbt commented 5 years ago

comment peux t on consulter notre solde

Translation from French: "how can we see our balance"

What I thought might be an answer / possible workaround for that purpose: Go into Settings, and change Primary Currency between "ETH" and "Fiat" and then look at the smaller text underneath. That doesn't work either, though:

image

If you right-click on the number you wish to see, then choose Inspect, you should be able to see the full value there: image

Definitely not a non-developer-user-friendly workaround!

danfinlay commented 3 years ago

Not sure if this issue is still live, but @rachelcope is redoing our number precision soon, so this is already addressed in another issue. Rachel can you link to that issue here?

tmashuang commented 3 years ago

We are actively improving on showing the exact amount values and truncating the width with an ellipsis, designs are in progress.

danjm commented 2 years ago

Easiest way to repro this for a developer is to just inspect the code and edit the html through the dev tools.

Screenshot from 2021-10-18 07-48-54

EHaracic commented 2 years ago

@danjm related to the display of the amount we need design decision how to show the large numbers. In the ticket there are two suggestions:

  1. A very large balance may be elided (e.g. "904...465.124 ETH") similar to how the address is (and you should be able to click on it to copy the full value, as with the address) OR
  2. The balance may use fewer significant digits in scientific notation.

Also, is this one resolved or partially resolved in the issue: #5570

danjm commented 2 years ago

Marking this as blocked for now. I will adjust it after it gets some design attention

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 12 months ago

I don't think this should be closed without an improvement.

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 8 months ago

I still don't think this should be closed without an improvement.

github-actions[bot] commented 4 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 3 months ago

I don't think this should be closed without an improvement.

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.