search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

UI RPC URL Discrepancy #6321

Closed CruzMolina closed 5 years ago

CruzMolina commented 5 years ago

Hey MM team!

Noticed a discrepancy on the UI.

Screen Shot 2019-03-19 at 9 37 37 AM

Are the current intentions to support the RPC URL as localhost 8545 or localhost 9545?

Thanks for your time! 🍫

MM: 6.2.2 Browser: Chrome Version 72.0.3626.121 (Official Build) (64-bit) OS: macOS 10.13.6 (High Sierra)

tmashuang commented 5 years ago

What's running on that port, Ganache, parity, geth, or etc.?

adrianmcli commented 5 years ago

Wouldn't it be nice if we could standardize on a port number for all local dev?

CruzMolina commented 5 years ago

@tmashuang ganache is running on 8545 in that screenshot.

I'm unable to have MM connect w/ ganache on 9545 unless I specify correct Custom RPC settings. The discrepancy is more that the text at the top shows http://127.0.0.1:9545 while ganache is running on 8545.

tmashuang commented 5 years ago

We're overriding default localhost data. So if there was a previous connection to http://127.0.01:9545 / http://127.0.01:7545 it will change the localhost 8545 nickname we show at the selected network. Fix will be in the next version.

joshmobley commented 5 years ago

Also, a long rpc endpoint url (with auth) breaks the UI.

It overflows the container preventing access to the account switcher.

bdresser commented 5 years ago

@joshmobley tracked in https://github.com/MetaMask/metamask-extension/issues/6094