CI Test: Require translations added when new language is included.

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites

https://metamask.io

Other

11.84k stars 4.83k forks source link

CI Test: Require translations added when new language is included. #6781

Open danfinlay opened 5 years ago

danfinlay commented 5 years ago

We should add a CI test that checks if there are new entries in the messages.json file, and if there are, require there are equivalent entries in (at least some of) the other languages files.

Bonus would be if @metamaskbot pinged the translators group when missing translations were detected, and included a protocol for them to PR their translations against the proposing branch.

Gudahtt commented 3 years ago

I don't think a strict requirement would be very practical for us right now. We add new messages fairly often, and we don't yet have the ability to request translations on-demand. Even if we did, it would severely slow down our development process if we left PRs to linger and go stale while waiting for translations.

Some tracking of our translation coverage is certainly warranted though, to keep us informed fo any gaps in languages that we want to commit to having high coverage.