MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.93k forks source link

Contacts Manager in Settings (Design Enhancements) #7069

Open cjeria opened 5 years ago

cjeria commented 5 years ago

Managing contacts in settings today has some navigation issues making it difficult to use. Below are some designs that address current usability issues with the dual goal of making it easier to build in both full screen and extension views. @danjm @whymarrh Let me know if you want to jump on a call to discuss.

Figma file

image

image

benjaminaaron commented 5 years ago

Love the new Contacts feature! 🌟

As a DApp developer I would love to be able to have a way to use the contacts throughout Browser-DApps as well. Not just for sending transactions but as parameters for calling smart contract functions. Something like long/right-press on a text field and among copy/paste etc. there is a new option "insert address from contacts" 📖 Or having a way to access MetaMask contacts via the web3 or unlocked window.ethereum object? So I could check if an inserted nickname has an entry in contacts 🔍 Maybe that is possible already? (I posted the same on a mobile issue)

jennypollack commented 5 years ago

@benjaminaaron https://ethereum-magicians.org/t/eip-2253-add-wallet-getaddressbook-json-rpc-method/3592, https://github.com/ethereum/EIPs/pull/2253 aim to address this, feel free to add your views

BboyAkers commented 3 years ago

Still working on it and will be pushing soon 🙂

danfinlay commented 2 years ago

One extra detail that might need consideration:

Our current address book stores addresses on a per-network basis. A user in this UI might not be thinking about their current network. It might help to add a network indication/selector above the address entry.

bschorchit commented 2 years ago

One extra detail that might need consideration:

Our current address book stores addresses on a per-network basis. A user in this UI might not be thinking about their current network. It might help to add a network indication/selector above the address entry.

This should also be revisited once we start supporting network specific addresses @kevinghim

BboyAkers commented 2 years ago

Quick update, I'm pushing an updated PR this week for this. So sorry for the delay on my end