search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.86k stars 4.84k forks source link

Console warning: "Invalid asm.js: Unexpected token" #7350

Open wbt opened 4 years ago

wbt commented 4 years ago

Describe the bug The above console warning is the first line visible when clicking to inspect the background page in Chrome. The warning is reported on bg-libs.js:1. This was observed after MetaMask crashed and had to be reloaded.

To Reproduce Steps to reproduce the behavior:

  1. In Chrome with MetaMask, visit chrome://extensions
  2. Click "background page" on the MetaMask tile
  3. View Console in the inspector that pops up.
  4. Observe the error in the first line.

Expected behavior No warnings about invalid Javascript.

Browser details (please complete the following information):

Gudahtt commented 3 years ago

I can reproduce this. The warning has no obvious user impact, but it is shown in the background console whenever the extension starts.

It looks like it's coming from the buffer package, specifically an older version that was brought in with the 3box dependency in #6972. We should be able to fix it by updating buffer to a newer version.

Edit: actually I'm not so sure :thinking: The error may in fact be coming from assert, which as inlined a function from buffer with a comment block to give attribution. It looks like the error is on the line where the comment block ends, as if the comment block was confusing the parser.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 11 months ago

I don't think this should be closed without an improvement.

github-actions[bot] commented 8 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 8 months ago

I still don't think this should be closed without an improvement.

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue was closed because there has been no follow up activity in the last 45 days. If you feel this was closed in error, please reopen and provide evidence on the latest release of the extension. Thank you for your contributions.