search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

Provide ability to export an account as standard json file #780

Closed danfinlay closed 6 years ago

danfinlay commented 7 years ago

Many wallets allow a standard-format json format of an ethereum wallet, password encrypted. It would be nice for us to allow exporting accounts in this way.

kennyrowe commented 7 years ago

+1

danfinlay commented 7 years ago

Since we're asking users with mis-generated accounts to export those accounts in the 3.0 migration guide, it would be nice to give them some format options.

The screen should allow private key, or JSON file.

JSON file will require a password, should include a confirmation box & warning text, and export only that account.

2-am-zzz commented 7 years ago

Could I get a link to what the format of a standard JSON file would look like?

danfinlay commented 7 years ago

Ethereum JS-wallet provides a method for generating this format:

toV3(password, [options]) https://github.com/ethereumjs/ethereumjs-wallet/blob/master/README.md

You can see an example in our tests where they test exports: https://github.com/ethereumjs/ethereumjs-wallet/blob/master/test/index.js

Tadasu85 commented 7 years ago

Any idea on when this feature will be completed?

danfinlay commented 7 years ago

No, unfortunately this is not a very high priority feature at the moment, even though it would be fairly simple to implement.

Since we already allow exporting private keys, most users we've talked to are already able to transport their accounts to other clients, and so this has met the immediate demand.

Also, we're in the middle of some heavy design thinking, so we're a little hesitant to add features that we might then have to re-design right after.

If you'd like, feel free to make an appeal for us to raise the priority, I'm aware of the security benefits. Any others?

licklake commented 6 years ago

I would love this feature too.

killua99 commented 6 years ago

I would love to have this feature

sparkso commented 6 years ago

wow it's 2018 and still no feature.

danfinlay commented 6 years ago

Sorry, it's just not very high priority. We're busy protecting users' funds, not caving to the latest snarky post on Github. We'll get to this when we have the bandwidth. Also, pull requests are welcome, this would be a pretty easy one to add.

danfinlay commented 6 years ago

Closing in favor of #1232.