search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.9k stars 4.85k forks source link

Incorrect error message when sending to an address with an invalid checksum #8080

Open alcuadrado opened 4 years ago

alcuadrado commented 4 years ago

Describe the bug

If you try to send to a non-lowercase address that doesn't have the right checksum/casing when using a dev network (e.g. Ganache), MM displays an error message saying that the network doesn't support ENS.

To Reproduce (REQUIRED) Steps to reproduce the behavior, libraries used with version number, and/or any setup information to easily reproduce:

  1. Connect MM to a ganache instance
  2. Send some eth to one of your MM addresses
  3. Try sending ETH to a checksummed address, but with a single char randomly changed.

Expected behavior

An error about the address checksum failing, being incorrect, or any other explanation, but not an ENS error.

Browser details (please complete the following information):

Gudahtt commented 3 years ago

Thanks for the report! I am unable to reproduce this on v8.1.11; it now says "recipient address invalid" if I type out an address that is mixed-case but not checksummed. When I paste it directly into the send field, it seems to work.

I'll leave this open as a request to enhance the error message, as "recipient address invalid" doesn't clearly communicate that it's a valid address with invalid casing, but I'd be curious to know if you can still repro the ENS error @alcuadrado

mirceanis commented 6 days ago

Is this issue still relevant?