search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

eth_getLogs: invalid argument 0: hex number with leading zero digits #8220

Open wbt opened 4 years ago

wbt commented 4 years ago

MetaMask's code for polling for events causes a lot of warnings in a Geth node log.

Details: https://github.com/ethereum/web3.js/issues/3379

wbt commented 4 years ago

Whatever used to work for getting events is no longer working for events coming in after the initial set (e.g. if additional events occur), and it appears to be due to this issue. I know that websocket support is definitely not a priority, but are there any plans to address this?

vandan commented 2 years ago

Could be an issue with eth-json-rpc-filters. Need to reproduce and investigate.

schiemon commented 2 years ago

Does anyone know any workaround? I have the same issue meaning I am able to load the initial set of events but fail with warnings (see title) in the rpc-node's console for events that happen later. I am using GoQuorum with Docker.

wbt commented 2 years ago

Does anyone know any workaround?

Ignoring the warnings? If you're seeing failures there should be errors somewhere.

schiemon commented 2 years ago

Unfortunately, I cannot reproduce the state anymore (it is O.K. now for some reason) but I did not remember seeing any errors in the node's console. I needed a workaround not for the warnings but for my web client which did not receive any events presumably because of this. When I come to this situation again I can give you more context.

schiemon commented 2 years ago

In the last days, my colleagues and I repeatedly get this error (err=)

WARN [10-07|13:34:38.661] Served eth_getLogs                       conn=172.16.239.1:61790 reqid=8138132905274248 t="569.75µs"  err="invalid argument 0: hex number with leading zero digits"

I am using GoQuorum@22.4.1 (via quickstart) and web3.js@1.8.0.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 1 year ago

I don't think this should be closed without an improvement.

github-actions[bot] commented 10 months ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

wbt commented 10 months ago

I still don't think this should be closed without an improvement.

laddhoffman commented 8 months ago

I've seen this error occur on a fresh instance of a node, until the transaction nonce gets up to 0x10.

vandan commented 3 months ago

@shanejonas Does this look like it may have something to do with padded zeros?