MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

Publish blog post regarding BIP44 derivation fix #854

Closed danfinlay closed 7 years ago

danfinlay commented 7 years ago

When we move off eth-lightwallet to ethereumjs-wallet, we will be using a slightly different BIP44 derivation implementation, and we're already aware the old version has a bug that is pending merge.

This means that for something like 1 in 1000 accounts, the generated account will be different than the original account.

There are a variety of ways we can prepare for this moment.

danfinlay commented 7 years ago

I'm leaning towards 3a combined with a solid blog post linking to axic's, linking to an older build, and guiding on how to recover any assets.

Easiest way might be to simply make the latest "old style" plugin readily available for download, with instructions on installing it, and using it to move tokens to the new account.

danfinlay commented 7 years ago

I say this both because it is the easiest way forward for us, where we don't spend too much energy on edge cases, and also because this is a developer beta, the few affected users who need to recover anything are already early adopters, and should be capable enough of following plugin installation instructions to recover anything they've lost.

danfinlay commented 7 years ago

Drafting the blog post in Quip: https://consensys.quip.com/L94mADKDFiCD

danfinlay commented 7 years ago

Medium draft online here: https://medium.com/metamask/metamask-3-migration-guide-914b79533cdd

danfinlay commented 7 years ago

I think I'm going to wait until I've added a label to the recovered accounts, so I can add a screenshot to this article before publishing it, but I've updated it for all our recovery strategies, so it's pretty good to go.

danfinlay commented 7 years ago

Blocked by screenshots including #950

danfinlay commented 7 years ago

Oh we can take those screenshots now, so this is no longer blocked. Ben also wanted to know when we'd be able to publish this, so I say we groom & publish it asap.

danfinlay commented 7 years ago

I've updated this with the latest screenshots, ready to publish whenever we all agree to.