MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

fix: bump ws resolutions; dedupe ws@7.x, ws@8.x #10018

Closed legobeat closed 2 weeks ago

legobeat commented 2 weeks ago

Resolves:

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0cf32b38c414985b825c7c7fd9cad4b99d5a3b77 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ff598b8-5f57-4ca5-be0e-c8939fcfdeee

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: db25916bdbdf1607b5908e8c3eac54b9921e0067 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10415b46-583d-4c5c-b965-3d4f8a18de19

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/socket.io-client@4.7.5 Transitive: filesystem, network, shell +5 2.21 MB darrachequesne
npm/ws@6.2.3 None 0 0 B

🚮 Removed packages: npm/socket.io-client@4.6.1, npm/ws@7.4.6

View full report↗︎

github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 47f3882988a0ac0000145dcb51e0746120bb32a8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/318a833b-b5c4-40bc-b188-b0fb27e2efcf

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b3f1d1a6c9cf2d6afdbd7cbd6f0467cf0f6613ef Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/461af28a-d22b-4190-b799-dd750849f1cc

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3ff05091974539e36b4479b9524497c5d279b2c4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b2ef4766-e706-44d8-9807-aceab6531aca

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
legobeat commented 2 weeks ago

Resolutions LGTM - let's wait for e2e smoke pass 👍

Looks like we may expect some failure which is addressed in #10021

leotm commented 2 weeks ago

ah think package.json conflict needs merge before smoke will re-trigger on bitrise

Screenshot 2024-06-18 at 2 33 50 PM
github-actions[bot] commented 2 weeks ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 188d1ba33b0aeb0480a097c1d2d18a51fc6306f4 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee87b07d-c112-4f9f-9157-24057f418eec

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
legobeat commented 2 weeks ago

ah think package.json conflict needs merge before smoke will re-trigger on bitrise

@leotm done!

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud