MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

chore: Resolve most ws to versions backfilled with fix #10019

Closed Cal-L closed 2 weeks ago

Cal-L commented 2 weeks ago

Description

PR to resolve ws advisory - https://github.com/advisories/GHSA-3h5v-q93c-6h6q In the change, we resolve the ws packages to use versions with backfilled fixes. https://github.com/advisories/GHSA-3h5v-q93c-6h6q

Related issues

Fixes:

Manual testing steps

Running yarn audit:ci should not show ws vulnerability

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/socket.io-client@4.7.5 Transitive: filesystem, network, shell +5 2.2 MB darrachequesne
npm/ws@6.2.3 None 0 0 B

🚮 Removed packages: npm/socket.io-client@4.6.1, npm/ws@7.4.6

View full report↗︎

legobeat commented 2 weeks ago

@Cal-L see also #10018

Cal-L commented 2 weeks ago

closed in favor of https://github.com/MetaMask/metamask-mobile/pull/10018