MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.14k stars 1.1k forks source link

feat: Feat/1673 bug report #10023

Closed Cal-L closed 3 months ago

Cal-L commented 3 months ago

Description

This PR adds a bug report section to the error boundary screen, which utilizes Sentry User Feedback API under the hood - https://docs.sentry.io/platforms/react-native/user-feedback/. The bug report will associate the issue ID, further assisting in debugging issues.

Related issues

Fixes: #1673 , #1448

Manual testing steps

Screenshots/Recordings

Before

After

Reporting the bug https://github.com/MetaMask/metamask-mobile/assets/10508597/1179d801-3d61-4aa8-8fcd-3c743a12452a

User feedback in Sentry https://github.com/MetaMask/metamask-mobile/assets/10508597/ede6bc57-0dda-450d-b833-60e6817564c7

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a3a98206d24538a085054fb7211eedab274a1ae3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/33c4e1b0-0aa3-4cd1-8e60-230e07656240

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
Cal-L commented 3 months ago

Q: What will we actually use this for given the current implementation only allows user to sends a feedback with the latest Sentry issue id, which I guess we already have logged in Sentry issues list, and doesn't allow to add a custom comment? Is this just a first step and we plan to add a custom input field later or add a screenshot?

AFAIK, the Sentry user feedback for React native doesn't have the ability to send screenshots. Could you elaborate on the custom comment part? The input allows users to provide comments.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
64.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud