MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.14k stars 1.1k forks source link

chore: resolution for ws library #10031

Closed tommasini closed 3 months ago

tommasini commented 3 months ago

Description

This PR resolves ws library of version 8.17.1 Currently we have multiple dependencies using ws library, and some of them are using version 7, making this upgrade a possible breaking change More details of ws version 8 breaking changes here

├─┬ @ethersproject/providers@5.7.2
│ └── ws@7.4.6
├─┬ @metamask/swaps-controller@9.0.0
│ └─┬ web3@4.9.0
│   └─┬ web3-providers-ws@4.0.7
│     ├─┬ isomorphic-ws@5.0.0
│     │ └── ws@8.17.0
│     └── ws@8.17.0
├─┬ @walletconnect/client@1.8.0
│ └─┬ @walletconnect/core@1.8.0
│   └─┬ @walletconnect/socket-transport@1.8.0
│     └── ws@7.5.3
├─┬ @walletconnect/core@2.13.0
│ └─┬ @walletconnect/jsonrpc-ws-connection@1.0.14
│   └── ws@7.5.9 deduped
├─┬ @wdio/browserstack-service@7.32.4
│ └─┬ webdriverio@7.32.4
│   ├─┬ devtools@7.32.0
│   │ └─┬ puppeteer-core@13.1.3
│   │   └── ws@8.2.3
│   └─┬ puppeteer-core@13.7.0
│     └── ws@8.5.0
├─┬ appium@1.22.3
│ ├─┬ appium-android-driver@4.54.0
│ │ └── ws@8.17.0
│ ├─┬ appium-base-driver@7.11.3
│ │ ├─┬ webdriverio@6.12.1
│ │ │ ├─┬ @types/puppeteer-core@5.4.0
│ │ │ │ └─┬ @types/puppeteer@7.0.4
│ │ │ │   └─┬ puppeteer@21.3.1
│ │ │ │     └─┬ puppeteer-core@21.3.1
│ │ │ │       └── ws@8.14.1
│ │ │ └─┬ puppeteer-core@5.5.0
│ │ │   └── ws@7.5.9
│ │ └── ws@8.17.0
│ ├─┬ appium-flutter-driver@0.0.36
│ │ └─┬ rpc-websockets@7.5.0
│ │   └── ws@8.17.0
│ ├─┬ appium-ios-driver@4.8.3
│ │ └─┬ appium-remote-debugger@5.7.0
│ │   └─┬ appium-base-driver@4.5.1
│ │     └── ws@7.5.9 deduped
│ ├─┬ appium-tizen-driver@1.1.1-beta.5
│ │ └─┬ appium-base-driver@4.5.1
│ │   └── ws@7.5.9 deduped
│ └─┬ appium-xcuitest-driver@3.62.0
│   └── ws@8.17.0
├─┬ detox@20.20.3
│ └── ws@7.5.9
├─┬ metro-config@0.73.10
│ └─┬ metro@0.73.10
│   ├─┬ metro-inspector-proxy@0.73.10
│   │ └── ws@7.5.9 deduped
│   └── ws@7.5.9 deduped
├─┬ react-native@0.71.15 invalid: "^0.56.0" from node_modules/react-native-jazzicon
│ ├─┬ @react-native-community/cli@10.2.6
│ │ └─┬ @react-native-community/cli-server-api@10.1.1
│ │   └── ws@7.5.9 deduped
│ ├─┬ react-devtools-core@4.28.4
│ │ └── ws@7.5.9 deduped
│ └── ws@6.2.2
└─┬ socket.io-client@4.6.1
  └─┬ engine.io-client@6.4.0
    └── ws@8.11.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/ws@8.17.1 None 0 0 B

🚮 Removed packages: npm/ws@7.4.6

View full report↗︎

legobeat commented 3 months ago
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1e759f4be465e0de7318e3ee8baac3dac26093f8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/89119db1-5844-4f8f-8e51-80cb9d6e4169

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

tommasini commented 3 months ago

closing in order of this PR