fix: swap completed event not firing - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

fix: swap completed event not firing #10033

Closed infiniteflower closed 1 week ago

infiniteflower commented 2 weeks ago

Description

This PR fixes the SWAP_COMPLETED event not firing after a transaction has been confirmed.

Related issues

Fixes: https://github.com/MetaMask/metamask-mobile/issues/9138

Manual testing steps

Do a Smart Transaction swap
Wait for tx to be confirmed
Observe TRACK event saved {"event": "Swap Completed" in the terminal

Repeat the above with a non Smart Transaction swap

Screenshots/Recordings

n/a

Before

After

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud