MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

feat: enable transaction simulations #10039

Closed OGPoyraz closed 1 week ago

OGPoyraz commented 1 week ago

Description

This PR enables transaction simulation in mobile which is implemented in the https://github.com/MetaMask/metamask-mobile/pull/9828

Related issues

This is the final task for mobile transaction simulation to enable it in mobile.

Manual testing steps

  1. Either go for the simple send or contract interaction
  2. See transaction simulations appear in the confirmation screen as loading state first - then simulates the transaction

Screenshots/Recordings

Recording could be found in the original implementation PR: https://github.com/MetaMask/metamask-mobile/pull/9828

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

NicolasMassart commented 1 week ago

Could you provide screenshots? I have no idea what it should look like.

OGPoyraz commented 1 week ago

Could you provide screenshots? I have no idea what it should look like.

Of course, you will find the recording in the original implementation PR https://github.com/MetaMask/metamask-mobile/pull/9828, now noted in the description. Thanks for raising it @NicolasMassart

metamaskbot commented 1 week ago

Missing release label release-7.26.0 on PR. Adding release label release-7.26.0 on PR and removing other release labels(release-7.27.0), as PR was cherry-picked in branch 7.26.0.