chore: Patch GasFeeController to revert API URL - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

chore: Patch GasFeeController to revert API URL #10044

Closed kylanhurt closed 1 week ago

kylanhurt commented 1 week ago

Description

There is a caching issue with some of the GasFeeController API URLs. The decision has been made to patch it for the time being.

Mobile Core issue: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=67345155 Slack conversation: https://consensys.slack.com/archives/C01V1L10W2E/p1718117049087139 Similar PR for Extension: https://github.com/MetaMask/metamask-extension/pull/25230 Core PR: https://github.com/MetaMask/core/pull/4403 Core branch: patch/extension-gas-api-endpoint

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=67345155

Manual testing steps

Go to app and make sure gas fees are being calculated correctly.

Screenshots/Recordings

Before

https://github.com/MetaMask/metamask-mobile/assets/6249205/bd45fcee-b64c-41c1-903e-1671c4a59392

After

https://github.com/MetaMask/metamask-mobile/assets/6249205/0099be03-fb5a-465c-9734-37451b6f5019

Pre-merge author checklist

[X] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[X] I've completed the PR template to the best of my ability
[X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 1 week ago

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1670c99546370089780768c979cc642343ba2698 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be553778-da28-4381-87f9-54a61013445d

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud