MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

chore: Chore/9924 - Enable `@typescript-eslint/no-explicit-any` as error rule #10048

Closed Cal-L closed 1 week ago

Cal-L commented 1 week ago

Description

This PR adds the @typescript-eslint/no-explicit-any eslint rule to prevent the usage of any. Aside from adding the rule to eslintrc, all of the changes ignores the rule for existing usage of any

This is the mobile equivalent of https://github.com/MetaMask/metamask-extension/pull/23531/ for extension

Related issues

Fixes: #9924

Manual testing steps

Screenshots/Recordings

Before

After

No lint errors

image

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 1 week ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c02c35265ab289ddf644c3f844b6a66994e4dbf5 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1dfdc625-b627-48af-bce0-ec604d1ed813

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Cal-L commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

Since this PR only ignores the use of any, we will ignore/bypass SonarCloud coverage failure