fix: fix stuck after `nonce too low` error - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

fix: fix stuck after `nonce too low` error #10049

Closed OGPoyraz closed 1 week ago

OGPoyraz commented 1 week ago

Description

This PR aims to fix send flow after getting nonce too low error.

Related issues

Fixes: https://github.com/MetaMask/metamask-mobile/issues/9729

Manual testing steps

Go to send flow
Before send, change it to lower nonce to get error
Get error and see it's redirected to the latest screen you're on
Try send flow again
It should successfully send

Screenshots/Recordings

Before

Forwarded from tests https://github.com/MetaMask/metamask-mobile/assets/104780023/655e0a17-0768-422b-a337-7909bc560e84

After

https://github.com/MetaMask/metamask-mobile/assets/7644512/a1265c59-b870-4fab-9b29-a2657cb78008

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sleepytanya commented 1 week ago

Bitrise build https://app.bitrise.io/build/998c80b8-fc0a-4193-9cac-229f25a01a01?tab=artifacts Samsung S24+, Android 14

Correct nonce transaction can be successfully send after attempt to send low nonce transaction:

https://github.com/MetaMask/metamask-mobile/assets/104780023/0f3f499c-ba2b-4eb2-be81-e5c97ec4011f

High nonce transaction can be successfully send after attempt to send low nonce transaction:

https://github.com/MetaMask/metamask-mobile/assets/104780023/78b32f13-68a5-4b66-a31a-aa9a43532f0d