MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

feat: new receive flow #10061

Open jonybur opened 1 week ago

jonybur commented 1 week ago

Description

Changes the QR/Receive screen flow. Unifies the QR code and the Receive screen. Makes the new screen show up as a standalone screen.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2384

Manual testing steps

  1. Go to each one of the triggers that open up the Receive screen
  2. Test that the screen opens, and that it opens on the correct screen.

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/11148144/ac6343d3-fc64-4f3c-8d25-9a5c4ced2b06

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 week ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

hesterbruikman commented 5 days ago

@yanrong-chen This is ready for your review. Please note that the QR got is not using dots as in the design. That would require a larger change.

hesterbruikman commented 5 days ago

@plasmacorral This PR updates QR code scanning and makes it part of a shared 'Receive' and 'Scan' flow. Could we kindly ask for your support to test this update against key import scanning, keystone use, etc.?