fix: Always mark the STX Opt In modal as seen

[dan437]

Description

It seems that after a redirection to Settings was added when a user clicks on "Manage in settings", it wasn't marking the modal as seen. This PR fixes it.

Related issues

Fixes:

Manual testing steps

1. Set up the app from scratch
2. Select "Enable" or "Manage in Settings" on the STX Opt In modal
3. You will not see the modal again, even when you switch to a different network and then back to Ethereum Mainnet

Screenshots/Recordings

Before

After

Pre-merge author checklist

• [ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[sleepytanya]

Bitrise build https://app.bitrise.io/build/1577a516-9b02-448b-86ba-64a697e0e49d?tab=artifacts Samsung S24+ STX opt-in modal displayed only once:

https://github.com/MetaMask/metamask-mobile/assets/104780023/4c34cea5-0c0d-4eb6-8453-9ac39caa1e56

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[bkirb]

https://github.com/MetaMask/metamask-mobile/assets/124314512/d0f90ce5-7798-46be-b2ba-ec4d6850173e

LGTM for QA, here is a screen recording