fix: origin on request sensor on in app browser

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.14k stars 1.1k forks source link

fix: origin on request sensor on in app browser #10069

Closed tommasini closed 2 months ago

tommasini commented 3 months ago

Description

More details on this thread

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.19%. Comparing base (b013c71) to head (0d96540). Report is 106 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #10069 +/- ## ========================================== + Coverage 47.24% 49.19% +1.94% ========================================== Files 1370 1423 +53 Lines 33304 34362 +1058 Branches 3586 3779 +193 ========================================== + Hits 15736 16904 +1168 + Misses 16607 16414 -193 - Partials 961 1044 +83 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tommasini commented 2 months ago

This PR will be replaced by an update on the webview package