search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.03k stars 1.06k forks source link

[Bug] Hardware wallet account name not reflecting on signing transaction screen #10079

Open vivek-consensys opened 4 days ago

vivek-consensys commented 4 days ago
  1. Connect QR/Ledger device on Metamask Mobile
  2. Go to test dapp
  3. Connect using hd wallet
  4. Personal sign using hd wallet
  5. Verify the sign transaction page displays

Expected: Hardware wallet account name to reflect with account list from homepage Actual: Hardware wallet account name does not reflect

Private Zenhub Video

Device: iPhone 13 OS: iOS 17.5.1 MM Version: 7.26.0 RC1 (1352)

dawnseeker8 commented 3 days ago

hi, the issue was caused by PreferenceController and AccountController state(regarding the account name) is difference. and this PR @owencraston create should be able to fix the issue https://github.com/MetaMask/metamask-mobile/pull/9724

once above PR merged, we will redo a tests again to make sure the above PR will address the issue.

bschorchit commented 13 hours ago

@vivek-consensys @dawnseeker8 do you if the mentioned PR should also fix this issue https://github.com/MetaMask/metamask-mobile/issues/10161 ?