MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.14k stars 1.1k forks source link

fix: Swap with unapproved token #10088

Closed tommasini closed 3 months ago

tommasini commented 3 months ago

Description

Awaiting for the result when adding a transaction before swapping for non approved tokens

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

callumelvidge commented 3 months ago

LGTM

metamaskbot commented 3 months ago

Missing release label release-7.26.0 on PR. Adding release label release-7.26.0 on PR and removing other release labels(release-7.27.0), as PR was cherry-picked in branch 7.26.0.