search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.14k stars 1.1k forks source link

chore: Update json-rpc-provider & json-rpc-middleware & json-rpc-filters #10098

Open tommasini opened 3 months ago

tommasini commented 3 months ago

Description

This PR is blocked due to breaking changes on the errors thrown to the dapps. More info in this thread

This PR includes:

Related issues

Fixes:

Manual testing steps

  1. Go to in-app browser
  2. Test connect with multiple dapps
  3. Perform transaciton on test dapp

Screenshots/Recordings

https://github.com/MetaMask/metamask-mobile/assets/46944231/c608d957-6684-40e2-8963-67a11dc610df

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 months ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@7.0.0 None 0 24.6 kB lgbot
npm/@metamask/eth-json-rpc-middleware@12.1.2 network +4 462 kB metamaskbot
npm/@metamask/json-rpc-engine@9.0.0 None 0 188 kB metamaskbot

🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@12.1.1, npm/eth-json-rpc-filters@4.2.2, npm/eth-json-rpc-middleware@4.3.0, npm/ethereumjs-common@1.5.2, npm/ethereumjs-tx@1.3.7, npm/level-errors@1.0.5, npm/merkle-patricia-tree@2.3.2

View full report↗︎

socket-security[bot] commented 3 months ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c6e47edecbb33ca933d7fa25965e7c8f81817f75 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5cd3b4ea-3953-4e13-b096-d6d52802d5ba

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ddfb55d9b187e74463d74ddabf94764944ce86c9 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbb6471d-e11b-4189-bd15-75232ee82fed

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 49cf6fa10ded0c7f305ca078e45a23b88214b4ff Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5bf5805-162b-4412-9712-f77192432d9d

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 010a194c05c75c90cd96a6d569f62adac5d2b238 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36deec35-0dff-4470-a857-54329d86cdf0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b7b8f28bf0022cc94b4912dc191ae2d735ca0698 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34830c05-7d3b-42d3-b326-bc50fac8350a

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
github-actions[bot] commented 3 months ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0debc0505a91d14bb9a9f9c6840555561310d340 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f5aa28d3-d608-4e2e-a025-41dd07661ca6

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.49%. Comparing base (b013c71) to head (0debc05). Report is 122 commits behind head on main.

Files Patch % Lines
app/core/WalletConnect/WalletConnectV2.ts 0.00% 2 Missing :warning:
app/core/BackgroundBridge/BackgroundBridge.js 66.66% 1 Missing :warning:
app/core/Snaps/SnapBridge.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10098 +/- ## ========================================== + Coverage 47.24% 49.49% +2.24% ========================================== Files 1370 1427 +57 Lines 33304 34420 +1116 Branches 3586 3801 +215 ========================================== + Hits 15736 17035 +1299 + Misses 16607 16323 -284 - Partials 961 1062 +101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

christopherferreira9 commented 3 months ago

Did a light check on SDK and it seems to be all good ✅

github-actions[bot] commented 2 days ago

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.