fix: stx on ramps missing origin - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.03k stars 1.06k forks source link

fix: stx on ramps missing origin #10099

Closed infiniteflower closed 4 days ago

infiniteflower commented 4 days ago

Description

This PR fixes an issue with Ramps and STX missing an origin. This will disable STX for all Ramps Send transactions.

Related issues

https://github.com/MetaMask/metamask-mobile/issues/10100

Fixes:

Manual testing steps

Turn on STX
Start an off ramp
Should be a normal tx

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 4 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarcloud[bot] commented 4 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

bkirb commented 4 days ago

LGTM for QA ✅

metamaskbot commented 3 days ago

More than one release label on PR. Keeping the lowest one (release-7.24.4) on PR and removing other release labels (release-7.27.0).