Open dawnseeker8 opened 3 days ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Attention: Patch coverage is 28.57143%
with 90 lines
in your changes missing coverage. Please review.
Project coverage is 49.44%. Comparing base (
b013c71
) to head (646cec4
). Report is 122 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
❌❌❌ pr_smoke_e2e_pipeline
failed on Bitrise! ❌❌❌
Commit hash: 449fab396733ebcc44add614461ab41bd636381a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6045017-3886-4834-8e99-f92887f5c3fb
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipeline
on Bitrise by removing and re-applying theRun Smoke E2E
label on the pull request
Failed conditions
27.5% Coverage on New Code (required ≥ 40%)
❌❌❌ pr_smoke_e2e_pipeline
failed on Bitrise! ❌❌❌
Commit hash: a710a749883a7f214dd90844df577b4e7c2beaa2 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8ced53a-955f-4b81-966b-d96c60683205
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipeline
on Bitrise by removing and re-applying theRun Smoke E2E
label on the pull request
Description
This PR will enable the multiple accounts supports for ledger devices. Following changes has been made in this PR:
LedgerSelectAccount
component to allow user select multiple accounts from ledger devices. (screen is similiar to QR code select account screen)remove accounts
for all hardware wallet accounts inAccountActions.tsx
file.remove accounts
andconnect accounts
engine.ts
code andledger.ts
to allow intialise the new ledger keyring and its middleware and transport object.BlockingActionModel
to supportonAnimationCompleted
event so that we can have better smooth model animation than before. (very lagging animation when some heavy operations like import multiple accounts happened in the background)Related issues
Fixes:
Manual testing steps
Connect Multiple Ledger accounts
Forget Multiple Ledger accounts
Forget Individual Ledger Account
Forget Individual QR Code Wallet Account
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist