MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.03k stars 1.06k forks source link

feat: Add the "is_smart_transaction" prop for the "Swap Started" event #10112

Closed dan437 closed 2 days ago

dan437 commented 3 days ago

Description

Adds the "is_smart_transaction" prop for the "Swap Started" event. We want to know if a swap was started as a smart transaction or just a regular transaction.

Related issues

Fixes:

Manual testing steps

  1. Trigger a swap on a testnet
  2. The "Swap Started" event will have the new "is_smart_transaction" prop

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 3 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov-commenter commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.48%. Comparing base (b013c71) to head (bd17f48). Report is 122 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10112 +/- ## ========================================== + Coverage 47.24% 49.48% +2.23% ========================================== Files 1370 1427 +57 Lines 33304 34426 +1122 Branches 3586 3802 +216 ========================================== + Hits 15736 17036 +1300 + Misses 16607 16328 -279 - Partials 961 1062 +101 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud