Temp/notification integration sdk fixes

Prithpal-Sooriya commented 3 months ago

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 3 months ago

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

14 out of 15 committers have signed the CLA. :white_check_mark: @EtherWizard33 :white_check_mark: @Jonathansoufer :white_check_mark: @NicolasMassart :white_check_mark: @dan437 :white_check_mark: @tommasini :white_check_mark: @infiniteflower :white_check_mark: @itsyoboieltr :white_check_mark: @vinistevam :white_check_mark: @tmashuang :white_check_mark: @sahar-fehri :white_check_mark: @sethkfman :white_check_mark: @chrisleewilcox :white_check_mark: @NicholasEllul :white_check_mark: @omridan159 :x: @Prithpal-Sooriya

socket-security[bot] commented 3 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask-previews/notification-services-controller@0.1.0-preview-4ca72848	network Transitive: environment, filesystem	`+111`	117 MB	metamaskbot
npm/@metamask-previews/profile-sync-controller@0.1.0-preview-4ca72848	network Transitive: environment	`+9`	19.4 MB	metamaskbot
npm/webextension-polyfill@0.12.0	None	`0`	205 kB	addons-robot

🚮 Removed packages: npm/@metamask/notification-services-controller@0.1.0

View full report↗︎

socket-security[bot] commented 3 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
Network access	npm/@metamask-previews/notification-services-controller@0.1.0-preview-4ca72848	Module: globalThis["fetch"] Location: Package overview	`package.json`	🚫
Network access	npm/@metamask-previews/profile-sync-controller@0.1.0-preview-4ca72848	Module: globalThis["fetch"] Location: Package overview	`package.json`	🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/@metamask-previews/notification-services-controller@0.1.0-preview-4ca72848
@SocketSecurity ignore npm/@metamask-previews/profile-sync-controller@0.1.0-preview-4ca72848

Prithpal-Sooriya commented 3 months ago

Not sure what happened here, I'm closing and re-opening.

Prithpal-Sooriya commented 3 months ago

Closing this, had a little sub-branch merge. Reopened this PR here: https://github.com/MetaMask/metamask-mobile/pull/10147

MetaMask / metamask-mobile