MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

feat: enables snaps feature flag on mobile #10121

Closed Jonathansoufer closed 3 days ago

Jonathansoufer commented 4 days ago

Description

This PR implements a new feature flag specific for snaps to enable the usage of snaps (embedded) while avoid users to install it (for now). This replaces the old snaps tag with preinstalled-snaps and external-snaps tags.

The whole installation flow is under external-snaps.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 4 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 4 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/snaps-controllers@9.2.0 Transitive: environment, filesystem, network +26 4.85 MB
npm/@metamask/snaps-rpc-methods@9.1.4 Transitive: filesystem, network +13 3.01 MB
npm/@metamask/snaps-sdk@6.0.0 network +5 1.13 MB metamaskbot
npm/@metamask/snaps-utils@7.7.0 network Transitive: filesystem +16 8.03 MB metamaskbot
npm/webextension-polyfill@0.12.0 None 0 205 kB addons-robot

🚮 Removed packages: npm/@metamask/snaps-rpc-methods@9.1.2, npm/@metamask/snaps-utils@7.4.1

View full report↗︎

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.53%. Comparing base (81bcdb2) to head (1edaae5).

:exclamation: Current head 1edaae5 differs from pull request most recent head abdebc1

Please upload reports for the commit abdebc1 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10121 +/- ## ======================================= Coverage 49.52% 49.53% ======================================= Files 1430 1430 Lines 34567 34568 +1 Branches 3823 3823 ======================================= + Hits 17121 17122 +1 Misses 16376 16376 Partials 1070 1070 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud