infiniteflower commented 4 days ago

Description

This PR fixes an issue only on Android, where if you had infinite (or very large) allowance on an ERC20 token this would result in a swaps-allowance-error being shown despite the API replying properly with a list of quotes.

Related issues

Fixes:

10037

Manual testing steps

Start MM app on Android
Set allowance on ERC20 very high (or select a token for which you have prior max allowance)
Go to Swaps
Fetch a quote where the ERC20 token is the From token
Observe quote being fetched properly with no errors

Screenshots/Recordings

Before

After

https://github.com/MetaMask/metamask-mobile/assets/139582705/22ce441f-0710-496c-b25d-4c17ec725cf3

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.