MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

test: disable privacy policy toast and whats new modal using fixtures #10134

Closed cortisiko closed 6 days ago

cortisiko commented 6 days ago

Description

Within the E2E tests that use fixtures, we want to disable the what's new modal in addition to the privacy policy toast message that appears as soon as you land on the wallet view. This shaves off ~7 mins of E2E run time on CI.

A new state (legalNotices) was added to the default fixture for the privacy policy. Furthermore, the Whats New modal version used in the default fixture was updated to match the most recent release: 7.24.3.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

See main before the PR is merged: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9f51cf6c-ffd3-4a7a-8aa4-f420a81547f9

After

Here is main after: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f15f1200-4164-4d56-a740-32687b3f5134

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 6 days ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6efaaa4e4a7622b08115810ecdaf7aa5aa2e8f3b Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb5600c2-2b40-4779-b16c-73e1e19bbd40

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud