MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

fix: fix checksum address for balance check #10135

Closed sahar-fehri closed 5 days ago

sahar-fehri commented 5 days ago

Description

When a user disables Batch account balance in settings, and go back to wallet view, they should be able to still see their balance.

Related issues

Fixes: https://github.com/MetaMask/metamask-mobile/issues/10132

Manual testing steps

  1. Go to Settings>Security & Privacy and disable Batch account balance
  2. Go back to wallet view
  3. Relaunch the app
  4. Unlock the app and you should be able to see your balance correctly

Screenshots/Recordings

Before

Check video in linked issue 🙏

After

https://github.com/MetaMask/metamask-mobile/assets/10994169/b26f20fd-d594-47ed-a689-106dd74de741

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 5 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 5 days ago

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5e758b77300a02fdf4ab359e4a5ba186ad73fc82 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4214124e-3443-4570-bab4-92be488d3341

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request
sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud