MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

feat: Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension #10139

Open jpuri opened 5 days ago

jpuri commented 5 days ago

Description

Add support for security alerts on zkSync, Berachain, Scroll and Metachain One on extension

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2717

Manual testing steps

  1. Add networks zkSync, Berachain, Scroll and Metachain One to extension
  2. Submit a malicious transaction on test dapp
  3. Ensure it is reported as malicious

Screenshots/Recordings

Screenshot 2024-07-02 at 6 27 37 PM

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 5 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security[bot] commented 4 days ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@blockaid/ppom_release@1.4.9 network 0 3.34 MB blockaiduser
npm/@metamask/ppom-validator@0.32.0 Transitive: environment, filesystem, network, unsafe +47 9.33 MB metamaskbot

🚮 Removed packages: npm/@blockaid/ppom_release@1.4.8, npm/@metamask/ppom-validator@0.31.0

View full report↗︎

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 15 hours ago

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 832b8b4fb3ca5ef6e91c81de8542fcbeef88f44d Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46255be2-a3a6-4f14-a116-3b31b9d8add9

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request