MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.04k stars 1.06k forks source link

fix: memoize token list #10142

Closed OGPoyraz closed 4 days ago

OGPoyraz commented 5 days ago

Description

This PR aims to address performance issue on simulations happens only on mainnet.

Related issues

Manual testing steps

There should be no performance discrepancies for simulations between mainnet and any other network.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

sleepytanya commented 5 days ago

Works perfectly! Bitrise build https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/677ffba8-5a0a-4e3b-b7bf-f783da9bba84?tab=artifacts Samsung S24+, Android 14 iOS 15, iOS version 17.15.1

iOS:

https://github.com/MetaMask/metamask-mobile/assets/104780023/e32af1bd-fbc7-479b-8836-cb5e4ee7ba25

https://github.com/MetaMask/metamask-mobile/assets/104780023/a4004e83-d827-4480-824c-ff45f4ec791b

https://github.com/MetaMask/metamask-mobile/assets/104780023/f3104e80-674b-4c68-aac6-31829d08974f

Android:

https://github.com/MetaMask/metamask-mobile/assets/104780023/9d71d6a5-4831-4d65-a152-79314400ffc7

https://github.com/MetaMask/metamask-mobile/assets/104780023/7171cd02-0706-4ed2-9cd7-f5df1a3236db

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud