fix: browser address bar - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

fix: browser address bar #10156

Open frankvonhoven opened 5 days ago

frankvonhoven commented 5 days ago

Description

See more details here

Related issues

Fixes: #1519

Manual testing steps

See related issue

Screenshots/Recordings

Before

After

https://github.com/MetaMask/metamask-mobile/assets/141057783/780bfed8-fd11-4aed-b88f-22de0a72bc4a

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 5 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tommasini commented 5 days ago

Could you add recordings of android behaviour as well?

sonarcloud[bot] commented 4 days ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud