Closed OGPoyraz closed 11 hours ago
Bitrise builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc732094-b76d-4ac8-b836-4e905ccdba53?tab=artifacts iPhone 15, iOS 17.5.1 Samsung S24+, Android 14
The app slows down significantly with simulations enabled. Waited for about 2 mins for Android and simulations never appeared.
iPhone:
https://github.com/MetaMask/metamask-mobile/assets/104780023/c80c1a02-072d-4acf-85f7-eadfbd984962
Samsung:
https://github.com/MetaMask/metamask-mobile/assets/104780023/d35de537-8839-49a7-ac8b-6b1f39d48b06
❌❌❌ pr_smoke_e2e_pipeline
failed on Bitrise! ❌❌❌
Commit hash: 13099411ae0c947d09959d7f3557d8646c9ac806 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a7b36234-29a6-4a7c-ad06-4ec9df8ac126
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipeline
on Bitrise by removing and re-applying theRun Smoke E2E
label on the pull request
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
❌❌❌ pr_smoke_e2e_pipeline
failed on Bitrise! ❌❌❌
Commit hash: 693af5979272585f2eeb58ba6eea8c1a83cdbfbe Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a02ce85e-3990-41aa-9594-23be768d5680
[!NOTE]
- You can kick off another
pr_smoke_e2e_pipeline
on Bitrise by removing and re-applying theRun Smoke E2E
label on the pull request
Bitrise QA builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/613024ad-473f-4ac9-bc82-112fa1f68a89?tab=artifacts
iPhone15, Samsung S24+ Token icons displayed correctly, no performance issues.
Android:
https://github.com/MetaMask/metamask-mobile/assets/104780023/e309432b-d974-472b-bac5-a52945f90bc7
iOS:
https://github.com/MetaMask/metamask-mobile/assets/104780023/da3bf6d3-b19f-4f6e-8456-220d50582337
Description
This PR aims to add support for
IdentIcon
component to use iconUrl for token entity fromtokenList
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist