chore: added the requirement for PRs to contain a QA label - Githubissues

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain

https://metamask.io

Other

2.04k stars 1.06k forks source link

chore: added the requirement for PRs to contain a QA label #10167

Closed sethkfman closed 1 day ago

sethkfman commented 4 days ago

Description

This PR add the requirement for all PRs to contain 1 of 3 QA labels:

No QA Needed
Run E2E Smoke
QA Passed

Related issues

Fixes:

Manual testing steps

PASS - Add no QA labels and see CI Check template and add labels / check-template-and-add-labels Fail
PASS - Add No QA Needed QA labels and see CI Check template and add labels / check-template-and-add-labels Pass
PASS - Add Run E2E Smoke QA labels and see CI Check template and add labels / check-template-and-add-labels Pass
PASS - Add QA Passed QA labels and see CI Check template and add labels / check-template-and-add-labels Pass

Screenshots/Recordings

Before

NA

After

NA

Pre-merge author checklist

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 4 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 4 days ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 40c50b49f327ff9639052143ce51d69fa122ea75 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1ae39fe-51d6-405b-bd61-9776545484f6

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

gauthierpetetin commented 1 day ago

Hi @sethkfman , it would be worth adding labels definitions to the labelling guidelines. Otherwise looks good to me!

sonarcloud[bot] commented 1 day ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud