[Bug]: ENS name missing in send flow for `TO` accounts

[plasmacorral]

Describe the Bug

When the TO address is in the account list, associated with an ENS, and selected from the account list on the Send to screen, the ENS name should appear in the TO address field instead of the default name "Account x" on both the Send to and Confirm screens.

This affects all account types: HD, Imported, QR, Ledger.

If you manually input the ENS name using the keyboard on the Send to screen, the ENS name appears there but not on the Confirm screen.

This issue was identified during the fQA of PR 9724 and is also present in production version 7.24.4.

Expected Behavior

If the TO address is a) in the accounts list, b) has a valid ENS, and c) does not have a custom user-input name, the ENS name should appear in the TO address fields instead of the default name "Account x."

If the account is not in the accounts list/contacts and is manually typed into the TO field, the ENS name should appear in the TO address field on the Confirm screen.

Screenshots/Recordings

Account list showing ENS name for Account 2 Send to screen showing Account 2 instead of ENS name Confirm screen showing Account 2 instead of ENS name

Steps to reproduce

Impact in both Send to and Confirm screens

1. Have an ENS name associated with an account in your wallet
2. Create a send tx and select that account from the account list
3. Note that ENS name is not shown in Send to or confirm screens

Alternative path only impacts Confirm screen:

1. Have an ENS name associated with an account in your wallet
2. Create a send tx and type the ENS name into the Send to screen
3. Tap Next
4. Note that ENS name is not shown in the Confirm screen

Error messages or log output

No response

Version

7.24.4

Build type

None

Device

Several

Operating system

iOS, Android

Additional context

Observed on all of the following: Samsung a515f running Android 12 with security 1/1/2024 Pixel 5a running Android 14 with security Apr 5, 2024 iPhone 13 mini running iOS 15.6.1 iPhone Xs running iOS 17.5.1

Severity

No response

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.