MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.16k stars 1.11k forks source link

[Bug] Duplicate events being recorded on Mixpanel with different properties listed on each #10302

Closed vivek-consensys closed 1 week ago

vivek-consensys commented 3 months ago
  1. Launch Mixpanel [Mobile Prod]
  2. Launch MM
  3. Recover from SRP
  4. Add hardware wallet
  5. Add Ledger account
  6. Verify the distinct ID from your device on Mixpanel
  7. Analyse the mixpanel events

Expected:- 1 event being listed per user action Actual:- 2 events being listed per user action

https://mixpanel.com/project/1979229/view/132079/app/profile#distinct_id=7A922DA7-FFEF-4CFA-B1CC-98A46990447B

image.png

https://mixpanel.com/project/3354001/view/3860937/app/profile#distinct_id=0f0fcafb-cdfc-427d-9d84-f0f5399f430a

image.png

1st event with 11 properties:-

image.png

2nd event with 12 properties:-

image.png

The device_type is listed on the 2nd event but not the 1st event.

dawnseeker8 commented 3 months ago

After investigation with Vivek together yesterday, we notice that this issue happen to all event types in both MM Mobile(QA) and MM mobile (production). Some metric events have been logged twice and one with proper properties logged and one without properties logged.

dawnseeker8 commented 3 months ago

just look at some MM mobile (production) metric, some version of app doesnt have issue, but some version of app start to have, i only saw some version after 7.17.1 (just randomly check) have this double event logs issue.

github-actions[bot] commented 2 weeks ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

github-actions[bot] commented 1 week ago

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.