search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.12k stars 1.09k forks source link

[Bug]: Unable to connect to ENS dapp in mobile browser #10614

Closed plasmacorral closed 2 days ago

plasmacorral commented 4 weeks ago

Describe the bug

Discovered while preparing a for migration test from release build of v7.28.0 build 1375. Attempting to connect to the dapp seems to not be working/responding on iOS, but causes MetaMask to stop on my android 14 device.

Expected behavior

Able to connect my account to a dapp, and if not handle that more gracefully than an app closure.

Screenshots/Recordings

Recording

Steps to reproduce

  1. Setup wallet
  2. open MetaMask mobile browser
  3. navigate to app.ens.domains
  4. Tap Connect
  5. Scroll to the right and tap MetaMask
  6. Note nothing seems to happen
  7. Tap Browser Wallet- no response
  8. Tap Wallet Connect
  9. Get prompted to select a wallet
  10. Tap MetaMask
  11. Note that MetaMask closes

Error messages or log output

No response

Detection stage

In production (default)

Version

7.28.0

Build type

None

Device

Pixel 5a

Operating system

Android

Additional context

No response

Severity

Once in this condition it is difficult to resolve as the app closes upon trying to close the browser tab.

Cal-L commented 4 weeks ago

This is a regression for 7.26.0, introduced in 7.27.0. Possibly related to react native webview upgrade - https://github.com/MetaMask/metamask-mobile/pull/7759 cc @joaoloureirop

joaoloureirop commented 3 weeks ago

This is a regression for 7.26.0, introduced in 7.27.0. Possibly related to react native webview upgrade - https://github.com/MetaMask/metamask-mobile/pull/7759 cc @joaoloureirop

The webview-upgrade PR introduced CSP compliance. This might break dapps that do not expect the provider to be initialized on our side

joaoloureirop commented 3 weeks ago

Metamask provider is now working.

iOS

https://github.com/user-attachments/assets/42f82f16-fc73-4fc3-887e-51678b014f58

Android

https://github.com/user-attachments/assets/669e3b84-39cd-436e-aa04-db43675a6602

Android still crashes after connect. Sentry tracking issue here

joaoloureirop commented 3 weeks ago

The Android crash root cause is a malformed SVG from https://app.ens.domains/favicon.svg

image

Shaik-Sirajuddin commented 3 weeks ago

facing similar crash when trying to connect to opensea.io or any other website using wallet connect within metamask browser