MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

Browser view's close and share button's color is not themed for dark mode #10918

Open brianacnguyen opened 2 months ago

brianacnguyen commented 2 months ago

What is this about?

When a user clicks on "Learn more" in the NFT, it opens a Metamask support page. The close/share button for thisBottomSheet is currently not themed for dark mode Simulator Screenshot - iPhone 15 Pro Max - 2024-08-29 at 19 11 59

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

No response

plasmacorral commented 1 month ago

I noticed a similar experience with the mobile client's in-app browser in v7.31.0 build 1432 on Android 14 with a pixel 7a. X to close a tab in dark mode was almost impossible to see.