search

MetaMask / metamask-mobile

Mobile web browser providing access to websites that use the Ethereum blockchain
https://metamask.io
Other
2.17k stars 1.12k forks source link

[Bug]: Multiple networks requests from zkswap.finance #11327

Open sleepytanya opened 2 months ago

sleepytanya commented 2 months ago

Describe the bug

Multiple networks requests originating from zkswap.finance, even when the wallet is not actively connected to the dApp. This behavior has not been observed in the production version. No issues with Uniswap, Pancake, Sushi swaps.

The bug happens only on fresh install. If the app is updated to RC 7.31.0 network requests work normally.

Probably related - https://github.com/MetaMask/metamask-mobile/issues/11341

Expected behavior

-

Screenshots/Recordings

https://github.com/user-attachments/assets/c6ae4ea9-ba27-472c-b597-3bc4b8a8ab6d

Steps to reproduce

  1. Go to zkswap.finance in MM browser
  2. Switch networks
  3. Observe multiple network requests and spam modal appear

Error messages or log output

No response

Detection stage

During release testing

Version

7.31.0 (1427)

Build type

None

Device

iPhone 15, Samsung S24+

Operating system

iOS, Android

Additional context

No response

Severity

No response

sleepytanya commented 2 months ago

Network requests in v7.31.0 (1429)

https://github.com/user-attachments/assets/caff4901-f626-4b77-a79e-5eb3886882e0

sleepytanya commented 2 months ago

The app freezes when switching from multiple networks to zkSync and then back to any other network:

https://github.com/user-attachments/assets/7b0cef65-b715-473f-9bdc-3af0755a2ec4

Cal-L commented 3 weeks ago

Changing status to ready for dev since this is just a bug that needs to be debugged + fixed.